net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 19 Mar 2023 12:33:29 +0000 (12:33 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 21 Mar 2023 12:21:47 +0000 (13:21 +0100)
pcs_get_state() implementations are not supposed to alter an_enabled.
Remove this assignment.

Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/E1pdsE5-00Dl2l-8F@rmk-PC.armlinux.org.uk
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/qca/qca8k-8xxx.c

index 55df4479ea30b1bc02ac76d4a7cabd4ff4ba97fa..62810903f1b31444af0625642dca3c90cc810a58 100644 (file)
@@ -1483,7 +1483,6 @@ static void qca8k_pcs_get_state(struct phylink_pcs *pcs,
 
        state->link = !!(reg & QCA8K_PORT_STATUS_LINK_UP);
        state->an_complete = state->link;
-       state->an_enabled = !!(reg & QCA8K_PORT_STATUS_LINK_AUTO);
        state->duplex = (reg & QCA8K_PORT_STATUS_DUPLEX) ? DUPLEX_FULL :
                                                           DUPLEX_HALF;