perf/x86/amd/uncore: Fix __percpu annotation
authorThomas Gleixner <tglx@linutronix.de>
Mon, 4 Mar 2024 10:12:18 +0000 (11:12 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 4 Mar 2024 10:58:36 +0000 (11:58 +0100)
The __percpu annotation in struct amd_uncore is confusing Sparse:

  uncore.c:649:10: sparse: warning: incorrect type in initializer (different address spaces)
  uncore.c:649:10: sparse:    expected void const [noderef] __percpu *__vpp_verify
  uncore.c:649:10: sparse:    got union amd_uncore_info *

The reason is that the __percpu annotation sits between the '*'
dereferencing operator and the member name.

Move it before the dereferencing operator to cure this.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20240304005104.394845326@linutronix.de
arch/x86/events/amd/uncore.c

index 5bf03c5758129569afdc394203033f95f0757c41..4ccb8fa483e613af8bade68e3718bda0e91acd38 100644 (file)
@@ -71,7 +71,7 @@ union amd_uncore_info {
 };
 
 struct amd_uncore {
-       union amd_uncore_info * __percpu info;
+       union amd_uncore_info  __percpu *info;
        struct amd_uncore_pmu *pmus;
        unsigned int num_pmus;
        bool init_done;