iio: pressure: mprls0025pa fix off-by-one enum
authorPetre Rodan <petre.rodan@subdimension.ro>
Fri, 29 Dec 2023 09:24:32 +0000 (11:24 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 23 Jan 2024 22:06:29 +0000 (22:06 +0000)
Fix off-by-one error in transfer-function property.
The honeywell,transfer-function property takes values between 1-3 so
make sure the proper enum gets used.

Fixes: 713337d9143ed ("iio: pressure: Honeywell mprls0025pa pressure sensor")
Co-developed-by: Andreas Klinger <ak@it-klinger.de>
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
Link: https://lore.kernel.org/r/20231229092445.30180-5-petre.rodan@subdimension.ro
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/pressure/mprls0025pa.c

index 30fb2de368210f40705f7d9f251d735354a46936..e3f0de020a40c964750f564fe1a0e25267f63f59 100644 (file)
@@ -323,6 +323,7 @@ static int mpr_probe(struct i2c_client *client)
        struct iio_dev *indio_dev;
        struct device *dev = &client->dev;
        s64 scale, offset;
+       u32 func;
 
        if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_READ_BYTE))
                return dev_err_probe(dev, -EOPNOTSUPP,
@@ -362,10 +363,11 @@ static int mpr_probe(struct i2c_client *client)
                        return dev_err_probe(dev, ret,
                                "honeywell,pmax-pascal could not be read\n");
                ret = device_property_read_u32(dev,
-                               "honeywell,transfer-function", &data->function);
+                               "honeywell,transfer-function", &func);
                if (ret)
                        return dev_err_probe(dev, ret,
                                "honeywell,transfer-function could not be read\n");
+               data->function = func - 1;
                if (data->function > MPR_FUNCTION_C)
                        return dev_err_probe(dev, -EINVAL,
                                "honeywell,transfer-function %d invalid\n",