net: mvneta: use ethtool_puts

Allows simplifying get_strings and avoids manual pointer manipulation.

Tested on Turris Omnia.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20241011195955.7065-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index f5d6acee0d37940daedcc1da7fa55bcdc6144641..1fb285fa0bdb7dda03738a0ed3bd49dee8877608 100644 (file)
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -4795,11 +4795,9 @@ static void mvneta_ethtool_get_strings(struct net_device *netdev, u32 sset,
                int i;
 
                for (i = 0; i < ARRAY_SIZE(mvneta_statistics); i++)
-                       memcpy(data + i * ETH_GSTRING_LEN,
-                              mvneta_statistics[i].name, ETH_GSTRING_LEN);
+                       ethtool_puts(&data, mvneta_statistics[i].name);
 
                if (!pp->bm_priv) {
-                       data += ETH_GSTRING_LEN * ARRAY_SIZE(mvneta_statistics);
                        page_pool_ethtool_stats_get_strings(data);
                }
        }