drm/exynos: simplify the return value handling in exynos_dp_get_modes()
authorJani Nikula <jani.nikula@intel.com>
Fri, 8 Mar 2024 16:03:46 +0000 (18:03 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 13 Mar 2024 08:44:14 +0000 (10:44 +0200)
Just use 0 and 1 directly, instead of the confusing local variable
that's always set to 0.

Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/64cc680f14d961cedb726a6fd5c6dfd53ca9bb85.1709913674.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/exynos/exynos_dp.c

index ca31bad6c5760dd9429df203a8a3d1c20d722a9f..f48c4343f4690f6dc288d1d8a1185a604d3c9152 100644 (file)
@@ -74,16 +74,15 @@ static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data,
 {
        struct exynos_dp_device *dp = to_dp(plat_data);
        struct drm_display_mode *mode;
-       int num_modes = 0;
 
        if (dp->plat_data.panel)
-               return num_modes;
+               return 0;
 
        mode = drm_mode_create(connector->dev);
        if (!mode) {
                DRM_DEV_ERROR(dp->dev,
                              "failed to create a new display mode.\n");
-               return num_modes;
+               return 0;
        }
 
        drm_display_mode_from_videomode(&dp->vm, mode);
@@ -94,7 +93,7 @@ static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data,
        drm_mode_set_name(mode);
        drm_mode_probed_add(connector, mode);
 
-       return num_modes + 1;
+       return 1;
 }
 
 static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data,