loop: remove extra variable in lo_req_flush
authorChaitanya Kulkarni <kch@nvidia.com>
Tue, 15 Feb 2022 21:33:09 +0000 (13:33 -0800)
committerJens Axboe <axboe@kernel.dk>
Sun, 27 Feb 2022 21:49:49 +0000 (14:49 -0700)
The local variable file is used to pass it to the vfs_fsync(). We can
get away with using lo->lo_backing_file instead of storing in a local
variable which is not used anywhere else.

No functional change in this patch.

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Link: https://lore.kernel.org/r/20220215213310.7264-4-kch@nvidia.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c

index 77c61eaaa6e4ead144ad3d2fc1bf7d2342450e9f..18b30a56bfc47106cbbfb5410d36031ce7048e25 100644 (file)
@@ -326,8 +326,7 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
 
 static int lo_req_flush(struct loop_device *lo, struct request *rq)
 {
-       struct file *file = lo->lo_backing_file;
-       int ret = vfs_fsync(file, 0);
+       int ret = vfs_fsync(lo->lo_backing_file, 0);
        if (unlikely(ret && ret != -EINVAL))
                ret = -EIO;