sfc: Really allow RX checksum offload to be disabled
authorBen Hutchings <bhutchings@solarflare.com>
Wed, 28 Oct 2009 09:50:44 +0000 (02:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Oct 2009 09:50:44 +0000 (02:50 -0700)
We have never checked the efx_nic::rx_checksum_enabled flag everywhere
we should, and since the switch to GRO we don't check it anywhere.
It's simplest to check it in the one place where we initialise the
per-packet checksummed flag.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/sfc/falcon.c

index 8776432f683c6f62e0c075bf93a904116b5c15bb..865638b035bf7bc78cb6677e77530b0486c7ef2a 100644 (file)
@@ -869,8 +869,9 @@ static void falcon_handle_rx_event(struct efx_channel *channel,
                 * UDP/IPv4, then we can rely on the hardware checksum.
                 */
                checksummed =
-                       rx_ev_hdr_type == FSE_AB_RX_EV_HDR_TYPE_IPV4_TCP ||
-                       rx_ev_hdr_type == FSE_AB_RX_EV_HDR_TYPE_IPV4_UDP;
+                       efx->rx_checksum_enabled &&
+                       (rx_ev_hdr_type == FSE_AB_RX_EV_HDR_TYPE_IPV4_TCP ||
+                        rx_ev_hdr_type == FSE_AB_RX_EV_HDR_TYPE_IPV4_UDP);
        } else {
                falcon_handle_rx_not_ok(rx_queue, event, &rx_ev_pkt_ok,
                                        &discard);