iio: proximity: sx_common: make use of regmap_clear_bits(), regmap_set_bits()

Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-39-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c
index fe07d1444ac37292aefe8438ef90810942d03be2..a95e9814aaf2adac8302cff531b81871c26792c6 100644 (file)
--- a/drivers/iio/proximity/sx_common.c
+++ b/drivers/iio/proximity/sx_common.c
@@ -111,17 +111,16 @@ static int sx_common_enable_irq(struct sx_common_data *data, unsigned int irq)
 {
        if (!data->client->irq)
                return 0;
-       return regmap_update_bits(data->regmap, data->chip_info->reg_irq_msk,
-                                 irq << data->chip_info->irq_msk_offset,
-                                 irq << data->chip_info->irq_msk_offset);
+       return regmap_set_bits(data->regmap, data->chip_info->reg_irq_msk,
+                              irq << data->chip_info->irq_msk_offset);
 }
 
 static int sx_common_disable_irq(struct sx_common_data *data, unsigned int irq)
 {
        if (!data->client->irq)
                return 0;
-       return regmap_update_bits(data->regmap, data->chip_info->reg_irq_msk,
-                                 irq << data->chip_info->irq_msk_offset, 0);
+       return regmap_clear_bits(data->regmap, data->chip_info->reg_irq_msk,
+                                irq << data->chip_info->irq_msk_offset);
 }
 
 static int sx_common_update_chan_en(struct sx_common_data *data,