ALSA: hda/realtek - Fixed ALC256 headphone no sound

Dell platform, plug headphone or headset, it had a chance to get no
sound from headphone.
Replace depop procedure will solve this issue.

Signed-off-by: Kailang Yang <kailang@realtek.com>
Link: https://lore.kernel.org/bb8e2de30d294dc287944efa0667685a@realtek.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4eafbcb40120c231827082ec8e1c9041d0548241..bf098c6fedb5106c57587a3b0c79be574386112f 100644 (file)
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4930,6 +4930,30 @@ static void alc269_fixup_hp_line1_mic1_led(struct hda_codec *codec,
        }
 }
 
+static void alc_hp_mute_disable(struct hda_codec *codec, unsigned int delay)
+{
+       if (delay <= 0)
+               delay = 75;
+       snd_hda_codec_write(codec, 0x21, 0,
+                   AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
+       msleep(delay);
+       snd_hda_codec_write(codec, 0x21, 0,
+                   AC_VERB_SET_PIN_WIDGET_CONTROL, 0x0);
+       msleep(delay);
+}
+
+static void alc_hp_enable_unmute(struct hda_codec *codec, unsigned int delay)
+{
+       if (delay <= 0)
+               delay = 75;
+       snd_hda_codec_write(codec, 0x21, 0,
+                   AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
+       msleep(delay);
+       snd_hda_codec_write(codec, 0x21, 0,
+                   AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
+       msleep(delay);
+}
+
 static const struct coef_fw alc225_pre_hsmode[] = {
        UPDATE_COEF(0x4a, 1<<8, 0),
        UPDATE_COEFEX(0x57, 0x05, 1<<14, 0),
@@ -5031,6 +5055,7 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec)
        case 0x10ec0236:
        case 0x10ec0256:
        case 0x19e58326:
+               alc_hp_mute_disable(codec, 75);
                alc_process_coef_fw(codec, coef0256);
                break;
        case 0x10ec0234:
@@ -5302,6 +5327,7 @@ static void alc_headset_mode_default(struct hda_codec *codec)
                alc_write_coef_idx(codec, 0x45, 0xc089);
                msleep(50);
                alc_process_coef_fw(codec, coef0256);
+               alc_hp_enable_unmute(codec, 75);
                break;
        case 0x10ec0234:
        case 0x10ec0274:
@@ -5399,6 +5425,7 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
        case 0x10ec0256:
        case 0x19e58326:
                alc_process_coef_fw(codec, coef0256);
+               alc_hp_enable_unmute(codec, 75);
                break;
        case 0x10ec0234:
        case 0x10ec0274:
@@ -5514,6 +5541,7 @@ static void alc_headset_mode_omtp(struct hda_codec *codec)
        case 0x10ec0256:
        case 0x19e58326:
                alc_process_coef_fw(codec, coef0256);
+               alc_hp_enable_unmute(codec, 75);
                break;
        case 0x10ec0234:
        case 0x10ec0274:
@@ -5619,25 +5647,21 @@ static void alc_determine_headset_type(struct hda_codec *codec)
                alc_write_coef_idx(codec, 0x06, 0x6104);
                alc_write_coefex_idx(codec, 0x57, 0x3, 0x09a3);
 
-               snd_hda_codec_write(codec, 0x21, 0,
-                           AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
-               msleep(80);
-               snd_hda_codec_write(codec, 0x21, 0,
-                           AC_VERB_SET_PIN_WIDGET_CONTROL, 0x0);
-
                alc_process_coef_fw(codec, coef0255);
                msleep(300);
                val = alc_read_coef_idx(codec, 0x46);
                is_ctia = (val & 0x0070) == 0x0070;
-
+               if (!is_ctia) {
+                       alc_write_coef_idx(codec, 0x45, 0xe089);
+                       msleep(100);
+                       val = alc_read_coef_idx(codec, 0x46);
+                       if ((val & 0x0070) == 0x0070)
+                               is_ctia = false;
+                       else
+                               is_ctia = true;
+               }
                alc_write_coefex_idx(codec, 0x57, 0x3, 0x0da3);
                alc_update_coefex_idx(codec, 0x57, 0x5, 1<<14, 0);
-
-               snd_hda_codec_write(codec, 0x21, 0,
-                           AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT);
-               msleep(80);
-               snd_hda_codec_write(codec, 0x21, 0,
-                           AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
                break;
        case 0x10ec0234:
        case 0x10ec0274: