drm/panthor: Use the BITS_PER_LONG macro
authorJinjie Ruan <ruanjinjie@huawei.com>
Mon, 2 Sep 2024 09:44:04 +0000 (17:44 +0800)
committerSteven Price <steven.price@arm.com>
Mon, 2 Sep 2024 09:43:54 +0000 (10:43 +0100)
sizeof(unsigned long) * 8 is the number of bits in an unsigned long
variable, replace it with BITS_PER_LONG macro to make them simpler.

And fix the warning:
WARNING: Comparisons should place the constant on the right side of the test
#23: FILE: drivers/gpu/drm/panthor/panthor_mmu.c:2696:
+       if (BITS_PER_LONG < va_bits) {

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240902094404.1943710-1-ruanjinjie@huawei.com
drivers/gpu/drm/panthor/panthor_mmu.c

index d47972806d50669f971c7a2908c94c3f2863068d..cd2bac54e761123a513336ef63a6e398b2d7e462 100644 (file)
@@ -2693,9 +2693,9 @@ int panthor_mmu_init(struct panthor_device *ptdev)
         * which passes iova as an unsigned long. Patch the mmu_features to reflect this
         * limitation.
         */
-       if (sizeof(unsigned long) * 8 < va_bits) {
+       if (va_bits > BITS_PER_LONG) {
                ptdev->gpu_info.mmu_features &= ~GENMASK(7, 0);
-               ptdev->gpu_info.mmu_features |= sizeof(unsigned long) * 8;
+               ptdev->gpu_info.mmu_features |= BITS_PER_LONG;
        }
 
        return drmm_add_action_or_reset(&ptdev->base, panthor_mmu_release_wq, mmu->vm.wq);