crypto: gcm - Fix error return code in crypto_gcm_create_common()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 17 Oct 2016 15:10:06 +0000 (15:10 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 25 Oct 2016 03:08:19 +0000 (11:08 +0800)
Fix to return error code -EINVAL from the invalid alg ivsize error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/gcm.c

index f624ac98c94e4d9b1910178feb279a610c603e28..39c261d819af1c746fb7d2e162e61c329d15e7ef 100644 (file)
@@ -672,11 +672,11 @@ static int crypto_gcm_create_common(struct crypto_template *tmpl,
        ctr = crypto_spawn_skcipher_alg(&ctx->ctr);
 
        /* We only support 16-byte blocks. */
+       err = -EINVAL;
        if (crypto_skcipher_alg_ivsize(ctr) != 16)
                goto out_put_ctr;
 
        /* Not a stream cipher? */
-       err = -EINVAL;
        if (ctr->base.cra_blocksize != 1)
                goto out_put_ctr;