crypto: ccp - Fix __sev_snp_shutdown_locked
authorAshish Kalra <ashish.kalra@amd.com>
Wed, 9 Apr 2025 19:34:29 +0000 (19:34 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 16 Apr 2025 07:16:22 +0000 (15:16 +0800)
Fix smatch warning:
drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked()
error: uninitialized symbol 'dfflush_error'.

Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-crypto/d9c2e79c-e26e-47b7-8243-ff6e7b101ec3@stanley.mountain/
Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/sev-dev.c

index 19fb51558a7d1597f976a230b9b4a3fad81e2d32..1ccff5e3f4bcce625183d82c9ede5677a508957f 100644 (file)
@@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic)
        ret = __sev_do_cmd_locked(SEV_CMD_SNP_SHUTDOWN_EX, &data, error);
        /* SHUTDOWN may require DF_FLUSH */
        if (*error == SEV_RET_DFFLUSH_REQUIRED) {
-               int dfflush_error;
+               int dfflush_error = SEV_RET_NO_FW_CALL;
 
                ret = __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &dfflush_error);
                if (ret) {