scsi: csiostor: Convert sysfs snprintf() to sysfs_emit()

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.

Link: https://lore.kernel.org/r/20220901015130.419307-1-zhangxuezhi3@gmail.com
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
index 9aafe0002ab12cc4c76880673aef9d79212d77a1..05e1a63e00c3a11266abca93910879a20ca7c7aa 100644 (file)
--- a/drivers/scsi/csiostor/csio_scsi.c
+++ b/drivers/scsi/csiostor/csio_scsi.c
@@ -1366,9 +1366,9 @@ csio_show_hw_state(struct device *dev,
        struct csio_hw *hw = csio_lnode_to_hw(ln);
 
        if (csio_is_hw_ready(hw))
-               return snprintf(buf, PAGE_SIZE, "ready\n");
-       else
-               return snprintf(buf, PAGE_SIZE, "not ready\n");
+               return sysfs_emit(buf, "ready\n");
+
+       return sysfs_emit(buf, "not ready\n");
 }
 
 /* Device reset */
@@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev,
 {
        struct csio_lnode *ln = shost_priv(class_to_shost(dev));
 
-       return snprintf(buf, PAGE_SIZE, "%x\n", ln->params.log_level);
+       return sysfs_emit(buf, "%x\n", ln->params.log_level);
 }
 
 /* Store debug level */
@@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev,
 {
        struct csio_lnode *ln = shost_priv(class_to_shost(dev));
 
-       return snprintf(buf, PAGE_SIZE, "%d\n", ln->num_reg_rnodes);
+       return sysfs_emit(buf, "%d\n", ln->num_reg_rnodes);
 }
 
 static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL);