tty: vt: remove unneeded assignment of EPecma to vc_priv
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Fri, 2 Feb 2024 06:55:51 +0000 (07:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 6 Feb 2024 14:37:37 +0000 (14:37 +0000)
vc_data::vc_priv is _always_ assigned before the ESgetpars case is
entered (in ESsquare). Therefore, there is no need to reset it when
leaving the ESgetpars case. Note the state is set to ESnormal few lines
above, so ESgetpars is entered only by the next CSI.

Therefore, this obfuscation can be removed.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20240202065608.14019-6-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt.c

index d04dbafc05173412872e0eb7b9a0918eca8a1d3e..69ebce0878f24079157b3bfadefbfd077edcd7da 100644 (file)
@@ -2421,10 +2421,9 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, int c)
                        }
                        return;
                }
-               if (vc->vc_priv != EPecma) {
-                       vc->vc_priv = EPecma;
+               if (vc->vc_priv != EPecma)
                        return;
-               }
+
                switch(c) {
                case 'G': case '`':
                        if (vc->vc_par[0])