drm/msm/dp: use eld_mutex to protect access to connector->eld
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fri, 6 Dec 2024 09:43:10 +0000 (11:43 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 16 Dec 2024 16:02:08 +0000 (18:02 +0200)
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Acked-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241206-drm-connector-eld-mutex-v2-7-c9bce1ee8bea@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/dp/dp_audio.c

index 74e01a5dd4195d5e0e04250663886f1116f25711..0fd5e0abaf07828157085bd680bfd3c7d32deb61 100644 (file)
@@ -414,8 +414,10 @@ static int msm_dp_audio_get_eld(struct device *dev,
                return -ENODEV;
        }
 
+       mutex_lock(&msm_dp_display->connector->eld_mutex);
        memcpy(buf, msm_dp_display->connector->eld,
                min(sizeof(msm_dp_display->connector->eld), len));
+       mutex_unlock(&msm_dp_display->connector->eld_mutex);
 
        return 0;
 }