net: dsa: microchip: ksz8: fix MDB configuration with non-zero VID
authorOleksij Rempel <o.rempel@pengutronix.de>
Fri, 24 Mar 2023 08:06:08 +0000 (09:06 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Mar 2023 11:17:32 +0000 (11:17 +0000)
FID is directly mapped to VID. However, configuring a MAC address with a
VID != 0 resulted in incorrect configuration due to an incorrect bit
mask. This kernel commit fixed the issue by correcting the bit mask and
ensuring proper configuration of MAC addresses with non-zero VID.

Fixes: 4b20a07e103f ("net: dsa: microchip: ksz8795: add support for ksz88xx chips")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/microchip/ksz_common.c

index 4929fb29ed061663403d09da886fc6623cae3e40..74c56d05ab0b9d582eb32c45480b5c6fd8df5ecd 100644 (file)
@@ -404,7 +404,7 @@ static const u32 ksz8863_masks[] = {
        [VLAN_TABLE_VALID]              = BIT(19),
        [STATIC_MAC_TABLE_VALID]        = BIT(19),
        [STATIC_MAC_TABLE_USE_FID]      = BIT(21),
-       [STATIC_MAC_TABLE_FID]          = GENMASK(29, 26),
+       [STATIC_MAC_TABLE_FID]          = GENMASK(25, 22),
        [STATIC_MAC_TABLE_OVERRIDE]     = BIT(20),
        [STATIC_MAC_TABLE_FWD_PORTS]    = GENMASK(18, 16),
        [DYNAMIC_MAC_TABLE_ENTRIES_H]   = GENMASK(1, 0),