ASoC: soc-component: add snd_soc_component_resume()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 26 Jul 2019 04:51:08 +0000 (13:51 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 5 Aug 2019 15:20:51 +0000 (16:20 +0100)
Current ALSA SoC is directly using component->driver->xxx,
thus, it is deep nested, and makes code difficult to read,
and is not good for encapsulation.
This patch adds new snd_soc_component_resume() and use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/875znp5rm2.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc-component.h
sound/soc/soc-component.c
sound/soc/soc-core.c

index cdb014f41fd1844734ba23685d3168eafc4f6fc1..1e3b70855ba71ec2dafee830aced7ab0c97bce8e 100644 (file)
@@ -354,5 +354,6 @@ int snd_soc_component_trigger(struct snd_soc_component *component,
                              struct snd_pcm_substream *substream,
                              int cmd);
 void snd_soc_component_suspend(struct snd_soc_component *component);
+void snd_soc_component_resume(struct snd_soc_component *component);
 
 #endif /* __SOC_COMPONENT_H */
index f0e63cd991c85c5b22592ac95a48f91a00c18542..cbae7672b72d33ac7a5c00d2fd058846ffd8fd06 100644 (file)
@@ -354,3 +354,10 @@ void snd_soc_component_suspend(struct snd_soc_component *component)
                component->driver->suspend(component);
        component->suspended = 1;
 }
+
+void snd_soc_component_resume(struct snd_soc_component *component)
+{
+       if (component->driver->resume)
+               component->driver->resume(component);
+       component->suspended = 0;
+}
index 855b19abc1d20799271e71881055dd25dbb7afd4..6cdfe7b2fe068d52152618ca87e5a727aa31b791 100644 (file)
@@ -593,9 +593,7 @@ static void soc_resume_deferred(struct work_struct *work)
 
        for_each_card_components(card, component) {
                if (component->suspended) {
-                       if (component->driver->resume)
-                               component->driver->resume(component);
-                       component->suspended = 0;
+                       snd_soc_component_resume(component);
                }
        }