sched/fair: Allow calculate_imbalance() to move idle cpus
authorPeter Zijlstra <peterz@infradead.org>
Tue, 29 Jul 2014 15:15:11 +0000 (17:15 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 12 Aug 2014 10:48:20 +0000 (12:48 +0200)
Allow calculate_imbalance() to 'create' idle cpus in the busiest group
if there are idle cpus in the local group.

Suggested-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140729152705.GX12054@laptop.lan
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c

index 94377254254e4ca5b3e5aa1c3780f2ad5c456b19..df1ed176c7b7bf1ea2610e5eefc3ba2e8da498cd 100644 (file)
@@ -6273,12 +6273,11 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
                return fix_small_imbalance(env, sds);
        }
 
-       if (busiest->group_type == group_overloaded) {
-               /*
-                * Don't want to pull so many tasks that a group would go idle.
-                * Except of course for the group_imb case, since then we might
-                * have to drop below capacity to reach cpu-load equilibrium.
-                */
+       /*
+        * If there aren't any idle cpus, avoid creating some.
+        */
+       if (busiest->group_type == group_overloaded &&
+           local->group_type   == group_overloaded) {
                load_above_capacity =
                        (busiest->sum_nr_running - busiest->group_capacity_factor);