drm/amd/display: Defer the setting of link hpd status for usb4/tbt
authorWayne Lin <wayne.lin@amd.com>
Mon, 27 May 2024 07:17:26 +0000 (15:17 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 14 Jun 2024 20:17:16 +0000 (16:17 -0400)
[Why & How]
Link hpd status is set during link detection process via dpia_query_hpd_status(),
doesn't need to explicitly set it during outbox irq. Remove it.

Reviewed-by: Jerry Zuo <jerry.zuo@amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com>
Signed-off-by: Wayne Lin <wayne.lin@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 43ee0618ebf5ccf18b4e8a82a2692f6df43a6dbe..43ac3e44d74f9eb0392f5c818146b18ec7dc5ae3 100644 (file)
@@ -863,7 +863,6 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
        struct dmcub_trace_buf_entry entry = { 0 };
        u32 count = 0;
        struct dmub_hpd_work *dmub_hpd_wrk;
-       struct dc_link *plink = NULL;
        static const char *const event_type[] = {
                "NO_DATA",
                "AUX_REPLY",
@@ -919,13 +918,6 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
                                }
                                INIT_WORK(&dmub_hpd_wrk->handle_hpd_work, dm_handle_hpd_work);
                                dmub_hpd_wrk->adev = adev;
-                               if (notify.type == DMUB_NOTIFICATION_HPD) {
-                                       plink = adev->dm.dc->links[notify.link_index];
-                                       if (plink) {
-                                               plink->hpd_status =
-                                                       notify.hpd_status == DP_HPD_PLUG;
-                                       }
-                               }
                                queue_work(adev->dm.delayed_hpd_wq, &dmub_hpd_wrk->handle_hpd_work);
                        } else {
                                dm->dmub_callback[notify.type](adev, &notify);