Input: MT - limit max slots

syzbot is reporting too large allocation at input_mt_init_slots(), for
num_slots is supplied from userspace using ioctl(UI_DEV_CREATE).

Since nobody knows possible max slots, this patch chose 1024.

Reported-by: syzbot <syzbot+0122fa359a69694395d5@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=0122fa359a69694395d5
Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c
index 14b53dac1253bfed5ad2dbd9b1dc22cdb9b80c28..6b04a674f832a048a3e021f92517d8529d27f652 100644 (file)
--- a/drivers/input/input-mt.c
+++ b/drivers/input/input-mt.c
@@ -46,6 +46,9 @@ int input_mt_init_slots(struct input_dev *dev, unsigned int num_slots,
                return 0;
        if (mt)
                return mt->num_slots != num_slots ? -EINVAL : 0;
+       /* Arbitrary limit for avoiding too large memory allocation. */
+       if (num_slots > 1024)
+               return -EINVAL;
 
        mt = kzalloc(struct_size(mt, slots, num_slots), GFP_KERNEL);
        if (!mt)