drm/panthor: Fix error code in panthor_gpu_init()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 2 Apr 2024 09:56:19 +0000 (12:56 +0300)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 3 Apr 2024 07:06:27 +0000 (09:06 +0200)
This code accidentally returns zero/success on error because of a typo.
It should be "irq" instead of "ret".  The other thing is that if
platform_get_irq_byname() were to return zero then the error code would
be cmplicated.  Fortunately, it does not so we can just change <= to
< 0.

Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/d753e684-43ee-45c2-a1fd-86222da204e1@moroto.mountain
drivers/gpu/drm/panthor/panthor_gpu.c

index 0f7c962440d3e226a9dd5c5810ee48d8757aae55..5251d8764e7d7a06aa81b078aef926147e310ea7 100644 (file)
@@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev)
                return ret;
 
        irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu");
-       if (irq <= 0)
-               return ret;
+       if (irq < 0)
+               return irq;
 
        ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK);
        if (ret)