ubifs: Set default assert action to read-only

Traditionally UBIFS just reported a failed assertion and moved on. The
drawback is that users will notice UBIFS bugs when it is too late, most
of the time when it is no longer about to mount. This makes bug hunting
problematic since valuable information from failing asserts is long gone
when UBIFS is dead. The other extreme, panic'ing on a failing assert is
also not worthwhile, we want users and developers give a chance to
collect as much debugging information as possible if UBIFS hits an
assert. Therefore go for the third option, switch to read-only mode when
an assert fails. That way UBIFS will not write possible bad data to the
MTD and gives users the chance to collect debugging information.

Signed-off-by: Richard Weinberger <richard@nod.at>

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index c31e7b4f1e1c88492a68046da678b44dadf90973..23e7042666a755dd361720e3a29b1a56585fee33 100644 (file)
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2027,6 +2027,7 @@ static struct ubifs_info *alloc_ubifs_info(struct ubi_volume_desc *ubi)
                INIT_LIST_HEAD(&c->orph_list);
                INIT_LIST_HEAD(&c->orph_new);
                c->no_chk_data_crc = 1;
+               c->assert_action = ASSACT_RO;
 
                c->highest_inum = UBIFS_FIRST_INO;
                c->lhead_lnum = c->ltail_lnum = UBIFS_LOG_LNUM;