debugfs: remove return value of debugfs_create_atomic_t()

No one checks the return value of debugfs_create_atomic_t(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20191016130332.GA28240@kroah.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/Documentation/filesystems/debugfs.txt b/Documentation/filesystems/debugfs.txt
index 1ec4a94b6e935362eaea0b59fdb5992057843cbf..ac6067a02f748e0da16b0452efe3cf23553b47ae 100644 (file)
--- a/Documentation/filesystems/debugfs.txt
+++ b/Documentation/filesystems/debugfs.txt
@@ -113,8 +113,8 @@ lower-case values, or 1 or 0.  Any other input will be silently ignored.
 
 Also, atomic_t values can be placed in debugfs with:
 
-    struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
-                               struct dentry *parent, atomic_t *value)
+    void debugfs_create_atomic_t(const char *name, umode_t mode,
+                                struct dentry *parent, atomic_t *value)
 
 A read of this file will get atomic_t values, and a write of this file
 will set atomic_t values.

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 8aac1a9007c9d0924f65c031f141e6eecc43e460..dede25247b81f72a2f8aeca2f1c42e8f67683459 100644 (file)
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -757,12 +757,11 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic_t_wo, NULL, debugfs_atomic_t_set,
  * @value: a pointer to the variable that the file should read to and write
  *         from.
  */
-struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
-                                struct dentry *parent, atomic_t *value)
+void debugfs_create_atomic_t(const char *name, umode_t mode,
+                            struct dentry *parent, atomic_t *value)
 {
-       return debugfs_create_mode_unsafe(name, mode, parent, value,
-                                       &fops_atomic_t, &fops_atomic_t_ro,
-                                       &fops_atomic_t_wo);
+       debugfs_create_mode_unsafe(name, mode, parent, value, &fops_atomic_t,
+                                  &fops_atomic_t_ro, &fops_atomic_t_wo);
 }
 EXPORT_SYMBOL_GPL(debugfs_create_atomic_t);
 

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index c127c159d10aea82ddeca9f332046b70fbdabbf1..19231e618c161a81a8afbbc57e57159bd9e682cc 100644 (file)
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -117,8 +117,8 @@ void debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent,
                        u64 *value);
 void debugfs_create_size_t(const char *name, umode_t mode,
                           struct dentry *parent, size_t *value);
-struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
-                                    struct dentry *parent, atomic_t *value);
+void debugfs_create_atomic_t(const char *name, umode_t mode,
+                            struct dentry *parent, atomic_t *value);
 struct dentry *debugfs_create_bool(const char *name, umode_t mode,
                                  struct dentry *parent, bool *value);
 
@@ -284,11 +284,10 @@ static inline void debugfs_create_size_t(const char *name, umode_t mode,
                                         struct dentry *parent, size_t *value)
 { }
 
-static inline struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,
-                                    struct dentry *parent, atomic_t *value)
-{
-       return ERR_PTR(-ENODEV);
-}
+static inline void debugfs_create_atomic_t(const char *name, umode_t mode,
+                                          struct dentry *parent,
+                                          atomic_t *value)
+{ }
 
 static inline struct dentry *debugfs_create_bool(const char *name, umode_t mode,
                                                 struct dentry *parent,