clockevents: Convert s[n]printf() to sysfs_emit()
authorLi Zhijian <lizhijian@fujitsu.com>
Thu, 14 Mar 2024 10:04:02 +0000 (18:04 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 9 Apr 2024 10:32:37 +0000 (12:32 +0200)
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240314100402.1326582-2-lizhijian@fujitsu.com
kernel/time/clockevents.c

index a7ca458cdd9cd6ebf138ca466b3f197d9e4e619f..60a6484831b1738f09f7103194b7138cb9da8764 100644 (file)
@@ -677,7 +677,7 @@ static ssize_t current_device_show(struct device *dev,
        raw_spin_lock_irq(&clockevents_lock);
        td = tick_get_tick_dev(dev);
        if (td && td->evtdev)
-               count = snprintf(buf, PAGE_SIZE, "%s\n", td->evtdev->name);
+               count = sysfs_emit(buf, "%s\n", td->evtdev->name);
        raw_spin_unlock_irq(&clockevents_lock);
        return count;
 }