crypto: api - use 'time_left' variable with wait_for_completion_killable_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 30 Apr 2024 12:14:42 +0000 (14:14 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 10 May 2024 09:15:24 +0000 (17:15 +0800)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_killable_timeout() causing patterns like:

timeout = wait_for_completion_killable_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/api.c

index 7f402107f0cc88863cd9d65904f83a590889a2a1..6aa5a3b4ed5e6a276a30bc0cafb19d65259c06cb 100644 (file)
@@ -202,18 +202,18 @@ static void crypto_start_test(struct crypto_larval *larval)
 static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
 {
        struct crypto_larval *larval = (void *)alg;
-       long timeout;
+       long time_left;
 
        if (!crypto_boot_test_finished())
                crypto_start_test(larval);
 
-       timeout = wait_for_completion_killable_timeout(
+       time_left = wait_for_completion_killable_timeout(
                &larval->completion, 60 * HZ);
 
        alg = larval->adult;
-       if (timeout < 0)
+       if (time_left < 0)
                alg = ERR_PTR(-EINTR);
-       else if (!timeout)
+       else if (!time_left)
                alg = ERR_PTR(-ETIMEDOUT);
        else if (!alg)
                alg = ERR_PTR(-ENOENT);