ntb_perf: pass correct struct device to dma_alloc_coherent
authorSanjay R Mehta <sanju.mehta@amd.com>
Wed, 6 May 2020 04:21:49 +0000 (23:21 -0500)
committerJon Mason <jdmason@kudzu.us>
Sat, 6 Jun 2020 00:02:08 +0000 (20:02 -0400)
Currently, ntb->dev is passed to dma_alloc_coherent
and dma_free_coherent calls. The returned dma_addr_t
is the CPU physical address. This works fine as long
as IOMMU is disabled. But when IOMMU is enabled, we
need to make sure that IOVA is returned for dma_addr_t.
So the correct way to achieve this is by changing the
first parameter of dma_alloc_coherent() as ntb->pdev->dev
instead.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
Signed-off-by: Arindam Nath <arindam.nath@amd.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/test/ntb_perf.c

index f73b126dde65b544ecead2fe7e1b48c8831b6bed..b4e3f6e4132070b8bfad32e3886b72d028d68af3 100644 (file)
@@ -557,7 +557,7 @@ static void perf_free_inbuf(struct perf_peer *peer)
                return;
 
        (void)ntb_mw_clear_trans(peer->perf->ntb, peer->pidx, peer->gidx);
-       dma_free_coherent(&peer->perf->ntb->dev, peer->inbuf_size,
+       dma_free_coherent(&peer->perf->ntb->pdev->dev, peer->inbuf_size,
                          peer->inbuf, peer->inbuf_xlat);
        peer->inbuf = NULL;
 }
@@ -586,8 +586,9 @@ static int perf_setup_inbuf(struct perf_peer *peer)
 
        perf_free_inbuf(peer);
 
-       peer->inbuf = dma_alloc_coherent(&perf->ntb->dev, peer->inbuf_size,
-                                        &peer->inbuf_xlat, GFP_KERNEL);
+       peer->inbuf = dma_alloc_coherent(&perf->ntb->pdev->dev,
+                                        peer->inbuf_size, &peer->inbuf_xlat,
+                                        GFP_KERNEL);
        if (!peer->inbuf) {
                dev_err(&perf->ntb->dev, "Failed to alloc inbuf of %pa\n",
                        &peer->inbuf_size);
@@ -1554,4 +1555,3 @@ static void __exit perf_exit(void)
        destroy_workqueue(perf_wq);
 }
 module_exit(perf_exit);
-