KVM: x86: change TLB flush indicator to bool
authorVihas Mak <makvihas@gmail.com>
Sun, 14 Nov 2021 16:43:12 +0000 (22:13 +0530)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 8 Dec 2021 09:24:44 +0000 (04:24 -0500)
change 0 to false and 1 to true to fix following cocci warnings:

        arch/x86/kvm/mmu/mmu.c:1485:9-10: WARNING: return of 0/1 in function 'kvm_set_pte_rmapp' with return type bool
        arch/x86/kvm/mmu/mmu.c:1636:10-11: WARNING: return of 0/1 in function 'kvm_test_age_rmapp' with return type bool

Signed-off-by: Vihas Mak <makvihas@gmail.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Wanpeng Li <wanpengli@tencent.com>
Cc: Jim Mattson <jmattson@google.com>
Cc: Joerg Roedel <joro@8bytes.org>
Message-Id: <20211114164312.GA28736@makvihas>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c

index c28cf7eeb79dbe3ff01b1bb6e8922492259c6bb1..ede63912b1ac376484f535f941dc613ec1b2a21d 100644 (file)
@@ -1454,7 +1454,7 @@ static bool kvm_set_pte_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head,
 {
        u64 *sptep;
        struct rmap_iterator iter;
-       int need_flush = 0;
+       bool need_flush = false;
        u64 new_spte;
        kvm_pfn_t new_pfn;
 
@@ -1466,7 +1466,7 @@ restart:
                rmap_printk("spte %p %llx gfn %llx (%d)\n",
                            sptep, *sptep, gfn, level);
 
-               need_flush = 1;
+               need_flush = true;
 
                if (pte_write(pte)) {
                        pte_list_remove(kvm, rmap_head, sptep);
@@ -1482,7 +1482,7 @@ restart:
 
        if (need_flush && kvm_available_flush_tlb_with_range()) {
                kvm_flush_remote_tlbs_with_address(kvm, gfn, 1);
-               return 0;
+               return false;
        }
 
        return need_flush;
@@ -1623,8 +1623,8 @@ static bool kvm_test_age_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head,
 
        for_each_rmap_spte(rmap_head, &iter, sptep)
                if (is_accessed_spte(*sptep))
-                       return 1;
-       return 0;
+                       return true;
+       return false;
 }
 
 #define RMAP_RECYCLE_THRESHOLD 1000