intel_th: Remove redundant initialization of pointer outp
authorColin Ian King <colin.i.king@gmail.com>
Mon, 29 Apr 2024 13:01:12 +0000 (16:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 May 2024 16:57:22 +0000 (18:57 +0200)
The pointer outp is being initialized with a value that is never
read. All the reads of outp occur after outp has neen set to an
appropriate value rather than using the first value is initialized
with. The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/hwtracing/intel_th/sth.c:73:15: warning: Value stored to
'outp' during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240429130119.1518073-9-alexander.shishkin@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/intel_th/sth.c

index 9ca8c4e045f8b6c95099d04a2131fe5955cb278d..428f595a28a05d371251b188c68a39877f2a38d0 100644 (file)
@@ -70,8 +70,8 @@ static ssize_t notrace sth_stm_packet(struct stm_data *stm_data,
        struct sth_device *sth = container_of(stm_data, struct sth_device, stm);
        struct intel_th_channel __iomem *out =
                sth_channel(sth, master, channel);
-       u64 __iomem *outp = &out->Dn;
        unsigned long reg = REG_STH_TRIG;
+       u64 __iomem *outp;
 
 #ifndef CONFIG_64BIT
        if (size > 4)