perf scripts python intel-pt-events: Delete unused 'event_attr variable
authorAlexander Pantyukhin <apantykhin@gmail.com>
Sat, 14 Jan 2023 13:05:33 +0000 (18:05 +0500)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 12 Apr 2023 15:19:42 +0000 (12:19 -0300)
The 'event_attr' is never used later, the var is ok be deleted.

Additional code simplification is to substitute string slice comparison
with "substring" function. This case no need to know the length specific
words.

Signed-off-by: Alexander Pantyukhin <apantykhin@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20230114130533.2877-1-apantykhin@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/scripts/python/intel-pt-events.py

index 1c76368f13c1aa4162afab03eb685e321f39bc02..346c89bd16d6d06ea64a538beb384576a84e5a5b 100644 (file)
@@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso, with_insn):
        print(start_str, src_str)
 
 def do_process_event(param_dict):
-       event_attr = param_dict["attr"]
        sample     = param_dict["sample"]
        raw_buf    = param_dict["raw_buf"]
        comm       = param_dict["comm"]
@@ -349,6 +348,7 @@ def do_process_event(param_dict):
        # callchain  = param_dict["callchain"]
        # brstack    = param_dict["brstack"]
        # brstacksym = param_dict["brstacksym"]
+       # event_attr = param_dict["attr"]
 
        # Symbol and dso info are not always resolved
        dso    = get_optional(param_dict, "dso")
@@ -359,13 +359,13 @@ def do_process_event(param_dict):
                print(glb_switch_str[cpu])
                del glb_switch_str[cpu]
 
-       if name[0:12] == "instructions":
+       if name.startswith("instructions"):
                if glb_src:
                        print_srccode(comm, param_dict, sample, symbol, dso, True)
                else:
                        print_instructions_start(comm, sample)
                        print_common_ip(param_dict, sample, symbol, dso)
-       elif name[0:8] == "branches":
+       elif name.startswith("branches"):
                if glb_src:
                        print_srccode(comm, param_dict, sample, symbol, dso, False)
                else: