cifsd: remove calling d_path in error paths
authorHyunchul Lee <hyc.lee@gmail.com>
Thu, 1 Apr 2021 08:23:21 +0000 (17:23 +0900)
committerSteve French <stfrench@microsoft.com>
Tue, 11 May 2021 00:15:32 +0000 (19:15 -0500)
calling d_path is excessive in error paths.

Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifsd/vfs.c

index 0ecdb5121c3aa39783b9b0710c5d0840d45a01ee..b509c90d911f35d0657aac35e7573eea98cd3a01 100644 (file)
@@ -312,9 +312,8 @@ int ksmbd_vfs_read(struct ksmbd_work *work, struct ksmbd_file *fp, size_t count,
 {
        struct file *filp;
        ssize_t nbytes = 0;
-       char *rbuf, *name;
+       char *rbuf;
        struct inode *inode;
-       char namebuf[NAME_MAX];
 
        rbuf = work->aux_payload_buf;
        filp = fp->filp;
@@ -348,11 +347,8 @@ int ksmbd_vfs_read(struct ksmbd_work *work, struct ksmbd_file *fp, size_t count,
 
        nbytes = kernel_read(filp, rbuf, count, pos);
        if (nbytes < 0) {
-               name = d_path(&filp->f_path, namebuf, sizeof(namebuf));
-               if (IS_ERR(name))
-                       name = "(error)";
                ksmbd_err("smb read failed for (%s), err = %zd\n",
-                               name, nbytes);
+                               fp->filename, nbytes);
                return nbytes;
        }