tpm: cr50: i2c: use jiffies to wait for tpm ready irq
authorMark Hasemeyer <markhas@chromium.org>
Tue, 14 Mar 2023 19:54:04 +0000 (13:54 -0600)
committerJarkko Sakkinen <jarkko@kernel.org>
Mon, 24 Apr 2023 13:15:52 +0000 (16:15 +0300)
When waiting for a tpm ready completion, the cr50 i2c driver incorrectly
assumes that the value of timeout_a is represented in milliseconds
instead of jiffies.

Remove the msecs_to_jiffies conversion.

Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_tis_i2c_cr50.c

index 77cea5b31c6e4b67eaabc9ec9839170095018935..376ae18a04ebb7c7a3f5d6116f2a2b7e626634f3 100644 (file)
@@ -100,8 +100,7 @@ static int tpm_cr50_i2c_wait_tpm_ready(struct tpm_chip *chip)
        }
 
        /* Wait for interrupt to indicate TPM is ready to respond */
-       if (!wait_for_completion_timeout(&priv->tpm_ready,
-                                        msecs_to_jiffies(chip->timeout_a))) {
+       if (!wait_for_completion_timeout(&priv->tpm_ready, chip->timeout_a)) {
                dev_warn(&chip->dev, "Timeout waiting for TPM ready\n");
                return -ETIMEDOUT;
        }