ASoC: Intel: avs: Fix null-ptr-deref in avs_component_probe()
authorHenry Martin <bsdhenrymartin@gmail.com>
Wed, 2 Apr 2025 14:14:11 +0000 (22:14 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 6 Apr 2025 22:18:19 +0000 (23:18 +0100)
devm_kasprintf() returns NULL when memory allocation fails. Currently,
avs_component_probe() does not check for this case, which results in a
NULL pointer dereference.

Fixes: 739c031110da ("ASoC: Intel: avs: Provide support for fallback topology")
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Ethan Carter Edwards <ethan@ethancedwards.com>
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Link: https://patch.msgid.link/20250402141411.44972-1-bsdhenrymartin@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/pcm.c

index dac463390da135d7972808cb55e1c2866dd736c7..7072bcf4e56f103b4b12e3dc6db83c29d95af8d8 100644 (file)
@@ -927,7 +927,8 @@ static int avs_component_probe(struct snd_soc_component *component)
                else
                        mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,
                                                             "hda-generic-tplg.bin");
-
+               if (!mach->tplg_filename)
+                       return -ENOMEM;
                filename = kasprintf(GFP_KERNEL, "%s/%s", component->driver->topology_name_prefix,
                                     mach->tplg_filename);
                if (!filename)