media: platform: xilinx: fix error return code of xvip_graph_init()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 5 Mar 2021 09:48:19 +0000 (10:48 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Mar 2021 09:19:45 +0000 (10:19 +0100)
When the list of xdev->notifier.asd_list is empty, no error return code
of xvip_graph_init() is assigned.
To fix this bug, ret is assigned with -ENOENT as error return code.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/xilinx/xilinx-vipp.c

index bf4015d852e3ca77f8e583b03271f85765089a29..2ce31d7ce1a63a9d16509150e58dbb758e049954 100644 (file)
@@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
 
        if (list_empty(&xdev->notifier.asd_list)) {
                dev_err(xdev->dev, "no subdev found in graph\n");
+               ret = -ENOENT;
                goto done;
        }