staging: r8188eu: off by one bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 29 Aug 2013 21:45:06 +0000 (00:45 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 30 Aug 2013 18:46:47 +0000 (11:46 -0700)
These should be "<" instead of "<=".  Also we can use the ARRAY_SIZE()
macro.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_cmd.c

index 859fc1919ad64c3dae916dd1b696e8619582d88c..9632ef48fbc1234877a19d031ade4633d14483ad 100644 (file)
@@ -367,7 +367,7 @@ _next:
 
                memcpy(pcmdbuf, pcmd->parmbuf, pcmd->cmdsz);
 
-               if (pcmd->cmdcode <= (sizeof(wlancmds) / sizeof(struct cmd_hdl))) {
+               if (pcmd->cmdcode < ARRAY_SIZE(wlancmds)) {
                        cmd_hdl = wlancmds[pcmd->cmdcode].h2cfuns;
 
                        if (cmd_hdl) {
@@ -385,7 +385,7 @@ _next:
 post_process:
 
                /* call callback function for post-processed */
-               if (pcmd->cmdcode <= (sizeof(rtw_cmd_callback) / sizeof(struct _cmd_callback))) {
+               if (pcmd->cmdcode < ARRAY_SIZE(rtw_cmd_callback)) {
                        pcmd_callback = rtw_cmd_callback[pcmd->cmdcode].callback;
                        if (pcmd_callback == NULL) {
                                RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("mlme_cmd_hdl(): pcmd_callback = 0x%p, cmdcode = 0x%x\n", pcmd_callback, pcmd->cmdcode));