bcma: gpio: Use generic_handle_irq_safe()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 19 Sep 2022 12:46:16 +0000 (14:46 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 19 Sep 2022 13:08:39 +0000 (15:08 +0200)
On PREEMPT_RT enabled kernels the demultiplex interrupt handler is force
threaded and runs with interrupts enabled. The invocation of
generic_handle_irq() with interrupts enabled triggers a lockdep warning due
to a non-irq safe lock acquisition.

Instead of disabling interrupts on the driver level, use
generic_handle_domain_irq_safe().

[ tglx: Split out from combo patch ]

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/YnkfWFzvusFFktSt@linutronix.de
drivers/bcma/driver_gpio.c

index fac8ff983aec864af32eb705c738268857052085..65fb9bad1577aaea2065e96bd6d78edefb9a1689 100644 (file)
@@ -115,7 +115,7 @@ static irqreturn_t bcma_gpio_irq_handler(int irq, void *dev_id)
                return IRQ_NONE;
 
        for_each_set_bit(gpio, &irqs, gc->ngpio)
-               generic_handle_irq(irq_find_mapping(gc->irq.domain, gpio));
+               generic_handle_domain_irq_safe(gc->irq.domain, gpio);
        bcma_chipco_gpio_polarity(cc, irqs, val & irqs);
 
        return IRQ_HANDLED;