mfd: rave-sp: Avoid unnecessary use of comma operator
authorSimon Horman <horms@kernel.org>
Tue, 23 Jan 2024 09:59:48 +0000 (09:59 +0000)
committerLee Jones <lee@kernel.org>
Fri, 23 Feb 2024 14:58:01 +0000 (14:58 +0000)
Although it does not seem to have any untoward side-effects,
the use of ';' to separate to assignments seems more appropriate than ','.

Flagged by clang-17 -Wcomma

No functional change intended. Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240123-rave-sp-comma-v1-1-84e9b15ba205@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/rave-sp.c

index 6ff84b2600c5438d5d7cf9387d2280e1a4a62d64..ea5fbcbbe4a56f8a7ba9dd3e57a87c54b97db56d 100644 (file)
@@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
 
        ackid       = atomic_inc_return(&sp->ackid);
        reply.ackid = ackid;
-       reply.code  = rave_sp_reply_code((u8)command),
+       reply.code  = rave_sp_reply_code((u8)command);
 
        mutex_lock(&sp->bus_lock);