net: pcs: xpcs: drop interface argument from internal functions
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 1 Oct 2024 16:04:16 +0000 (17:04 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 00:31:59 +0000 (17:31 -0700)
Now that we no longer use the "interface" argument when creating the
XPCS sub-driver, remove it from xpcs_create() and xpcs_init_iface().

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1svfMG-005ZI9-3k@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-xpcs.c

index 7c6c40ddf722e3000f438eeed1e852eff40a0a01..2d8cc3959b4c1a67d16348878aafe68d5203119b 100644 (file)
@@ -1483,7 +1483,7 @@ static int xpcs_init_id(struct dw_xpcs *xpcs)
        return 0;
 }
 
-static int xpcs_init_iface(struct dw_xpcs *xpcs, phy_interface_t interface)
+static int xpcs_init_iface(struct dw_xpcs *xpcs)
 {
        if (xpcs->info.pma == WX_TXGBE_XPCS_PMA_10G_ID)
                xpcs->pcs.poll = false;
@@ -1493,8 +1493,7 @@ static int xpcs_init_iface(struct dw_xpcs *xpcs, phy_interface_t interface)
        return 0;
 }
 
-static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,
-                                  phy_interface_t interface)
+static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev)
 {
        struct dw_xpcs *xpcs;
        int ret;
@@ -1511,7 +1510,7 @@ static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,
        if (ret)
                goto out_clear_clks;
 
-       ret = xpcs_init_iface(xpcs, interface);
+       ret = xpcs_init_iface(xpcs);
        if (ret)
                goto out_clear_clks;
 
@@ -1546,7 +1545,7 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
        if (IS_ERR(mdiodev))
                return ERR_CAST(mdiodev);
 
-       xpcs = xpcs_create(mdiodev, interface);
+       xpcs = xpcs_create(mdiodev);
 
        /* xpcs_create() has taken a refcount on the mdiodev if it was
         * successful. If xpcs_create() fails, this will free the mdio
@@ -1584,7 +1583,7 @@ struct dw_xpcs *xpcs_create_fwnode(struct fwnode_handle *fwnode,
        if (!mdiodev)
                return ERR_PTR(-EPROBE_DEFER);
 
-       xpcs = xpcs_create(mdiodev, interface);
+       xpcs = xpcs_create(mdiodev);
 
        /* xpcs_create() has taken a refcount on the mdiodev if it was
         * successful. If xpcs_create() fails, this will free the mdio