net: stmmac: sti: Use syscon_regmap_lookup_by_phandle_args

Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
syscon_regmap_lookup_by_phandle() combined with getting the syscon
argument.  Except simpler code this annotates within one line that given
phandle has arguments, so grepping for code would be easier.

There is also no real benefit in printing errors on missing syscon
argument, because this is done just too late: runtime check on
static/build-time data.  Dtschema and Devicetree bindings offer the
static/build-time check for this already.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250112-syscon-phandle-args-net-v1-4-3423889935f7@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
index de9b6dfef15b3d0a503a3b55b3e9a42ee68c6141..f25461c292fecc02541f5576c1d4a3a3685f6b28 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
@@ -199,16 +199,11 @@ static int sti_dwmac_parse_data(struct sti_dwmac *dwmac,
        if (res)
                dwmac->clk_sel_reg = res->start;
 
-       regmap = syscon_regmap_lookup_by_phandle(np, "st,syscon");
+       regmap = syscon_regmap_lookup_by_phandle_args(np, "st,syscon",
+                                                     1, &dwmac->ctrl_reg);
        if (IS_ERR(regmap))
                return PTR_ERR(regmap);
 
-       err = of_property_read_u32_index(np, "st,syscon", 1, &dwmac->ctrl_reg);
-       if (err) {
-               dev_err(dev, "Can't get sysconfig ctrl offset (%d)\n", err);
-               return err;
-       }
-
        err = of_get_phy_mode(np, &dwmac->interface);
        if (err && err != -ENODEV) {
                dev_err(dev, "Can't get phy-mode\n");