net: phylink: move MLO_AN_FIXED resolve handling to if() statement
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 8 Nov 2024 16:01:50 +0000 (16:01 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Nov 2024 03:05:13 +0000 (19:05 -0800)
The switch() statement doesn't sit very well with the preceeding if()
statements, and results in excessive indentation that spoils code
readability. Begin cleaning this up by converting the MLO_AN_FIXED case
to an if() statement.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1t9RQk-002Fen-1A@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phylink.c

index 65e81ef2225d3c8d87c28750a78c0c60a9f67589..bb20ae5674e559eacbf7417ef88b4e488df91857 100644 (file)
@@ -1463,6 +1463,9 @@ static void phylink_resolve(struct work_struct *w)
        } else if (pl->mac_link_dropped) {
                link_state.link = false;
                retrigger = true;
+       } else if (pl->cur_link_an_mode == MLO_AN_FIXED) {
+               phylink_get_fixed_state(pl, &link_state);
+               mac_config = link_state.link;
        } else {
                switch (pl->cur_link_an_mode) {
                case MLO_AN_PHY:
@@ -1470,11 +1473,6 @@ static void phylink_resolve(struct work_struct *w)
                        mac_config = link_state.link;
                        break;
 
-               case MLO_AN_FIXED:
-                       phylink_get_fixed_state(pl, &link_state);
-                       mac_config = link_state.link;
-                       break;
-
                case MLO_AN_INBAND:
                        phylink_mac_pcs_get_state(pl, &link_state);