scsi: ufs: ufs-qcom: Drop unnecessary NULL checks
authorAndrew Halaney <ahalaney@redhat.com>
Thu, 1 Dec 2022 23:08:07 +0000 (17:08 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 30 Dec 2022 21:10:38 +0000 (21:10 +0000)
This code path is only called through one function, and the HBA struct is
already accessed in ufshcd_vops_dbg_register_dump() prior to calling so
there is no way for it to be NULL.

Likewise, the print_fn callback is always supplied within this driver and
is always provided.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Asutosh Das <quic_asutoshd@quicinc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-qcom.c

index 8ad1415e10b637ac927b4aca3a5ed7c4de801ab4..70e25f9f8ca8a342bb6ef83d6d556827ce30fdc1 100644 (file)
@@ -1202,15 +1202,6 @@ static void ufs_qcom_print_hw_debug_reg_all(struct ufs_hba *hba,
        u32 reg;
        struct ufs_qcom_host *host;
 
-       if (unlikely(!hba)) {
-               pr_err("%s: hba is NULL\n", __func__);
-               return;
-       }
-       if (unlikely(!print_fn)) {
-               dev_err(hba->dev, "%s: print_fn is NULL\n", __func__);
-               return;
-       }
-
        host = ufshcd_get_variant(hba);
        if (!(host->dbg_print_en & UFS_QCOM_DBG_PRINT_REGS_EN))
                return;