media: ti-vpe: cal: fix error handling in cal_camerarx_create
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Mon, 14 Jun 2021 11:23:12 +0000 (13:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 12 Jul 2021 10:34:11 +0000 (12:34 +0200)
cal_camerarx_create() doesn't handle error returned from
cal_camerarx_sd_init_cfg(). Fix this.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/ti-vpe/cal-camerarx.c

index 124a4e2bdefe078dac19f745d92ebe6dc502929c..e2e384a887ac2bf979f66cc1652216aa63ccddc4 100644 (file)
@@ -845,7 +845,9 @@ struct cal_camerarx *cal_camerarx_create(struct cal_dev *cal,
        if (ret)
                goto error;
 
-       cal_camerarx_sd_init_cfg(sd, NULL);
+       ret = cal_camerarx_sd_init_cfg(sd, NULL);
+       if (ret)
+               goto error;
 
        ret = v4l2_device_register_subdev(&cal->v4l2_dev, sd);
        if (ret)