staging: r8188eu: Use sizeof dereferenced pointer in kzalloc()
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Tue, 8 Feb 2022 18:04:25 +0000 (19:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Feb 2022 16:10:16 +0000 (17:10 +0100)
checkpatch.pl emits the following warning:

CHECK: Prefer kzalloc(sizeof(*pcmd)...) over kzalloc(sizeof(struct cmd_obj)...)
+       pcmd = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);

CHECK: Prefer kzalloc(sizeof(*psetkeyparm)...) over kzalloc(sizeof(struct setkey_parm)...)
+       psetkeyparm = kzalloc(sizeof(struct setkey_parm), GFP_KERNEL).

According to the above "CHECK[S]", use the preferred style in the two kzalloc()
of rtw_set_key().

Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20220208180426.27455-2-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme.c

index 038bddc361c35b776f1d6f0c930366cc00156a07..f5b2df72e0f4d26c953f89e7857adf176ba4d1cd 100644 (file)
@@ -1600,12 +1600,12 @@ int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, in
        struct mlme_priv                *pmlmepriv = &adapter->mlmepriv;
        int     res = _SUCCESS;
 
-       pcmd = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
+       pcmd = kzalloc(sizeof(*pcmd), GFP_KERNEL);
        if (!pcmd) {
                res = _FAIL;  /* try again */
                goto exit;
        }
-       psetkeyparm = kzalloc(sizeof(struct setkey_parm), GFP_KERNEL);
+       psetkeyparm = kzalloc(sizeof(*psetkeyparm), GFP_KERNEL);
        if (!psetkeyparm) {
                kfree(pcmd);
                res = _FAIL;