ext4: Don't set EXT4_STATE_MAY_INLINE_DATA for ea inodes
authorJulian Sun <sunjunchao2870@gmail.com>
Tue, 7 Jan 2025 04:46:59 +0000 (12:46 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 13 Mar 2025 13:57:19 +0000 (09:57 -0400)
Setting the EXT4_STATE_MAY_INLINE_DATA flag for ea inodes
is meaningless because ea inodes do not use functions
like ext4_write_begin().

Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20250107044702.1836852-3-sunjunchao2870@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ialloc.c

index 21d228073d7954fe419a50c2536a86c7f6e833e4..9ac5d1426f5441925adfab8e56f5bd8803654b59 100644 (file)
@@ -1298,7 +1298,7 @@ got:
        ei->i_extra_isize = sbi->s_want_extra_isize;
        ei->i_inline_off = 0;
        if (ext4_has_feature_inline_data(sb) &&
-           (!(ei->i_flags & EXT4_DAX_FL) || S_ISDIR(mode)))
+           (!(ei->i_flags & (EXT4_DAX_FL|EXT4_EA_INODE_FL)) || S_ISDIR(mode)))
                ext4_set_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
        ret = inode;
        err = dquot_alloc_inode(inode);