regulator: da9062: Annotate struct da9062_regulators with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:53:31 +0000 (10:53 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 9 Oct 2023 12:14:23 +0000 (13:14 +0100)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct da9062_regulators.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922175330.work.066-kees@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9062-regulator.c

index 1d354db0c1bd1d08911ad4335aad9a847a672912..e0c96f10e570cec67ce3a9455a24d3d072a7af5e 100644 (file)
@@ -73,7 +73,7 @@ struct da9062_regulators {
        int                                     irq_ldo_lim;
        unsigned                                n_regulators;
        /* Array size to be defined during init. Keep at end. */
-       struct da9062_regulator                 regulator[];
+       struct da9062_regulator                 regulator[] __counted_by(n_regulators);
 };
 
 /* Regulator operations */