fs/proc/inode.c: annotate close_pdeo() for sparse
authorJules Irenge <jbi.octave@gmail.com>
Tue, 7 Apr 2020 03:08:55 +0000 (20:08 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 7 Apr 2020 17:43:42 +0000 (10:43 -0700)
Fix sparse locking imbalance warning:

warning: context imbalance in close_pdeo() - unexpected unlock

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200227201538.GA30462@avx2
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/inode.c

index 1e730ea1dcd646b9168a67df99e4ff4bc978cfd8..05d31c464bee084a8398a3a15abc1b3565a58374 100644 (file)
@@ -202,6 +202,7 @@ static void unuse_pde(struct proc_dir_entry *pde)
 
 /* pde is locked on entry, unlocked on exit */
 static void close_pdeo(struct proc_dir_entry *pde, struct pde_opener *pdeo)
+       __releases(&pde->pde_unload_lock)
 {
        /*
         * close() (proc_reg_release()) can't delete an entry and proceed: