net: dsa: realtek: make use of dev_err_cast_probe()
authorHongbo Li <lihongbo22@huawei.com>
Wed, 28 Aug 2024 12:18:05 +0000 (20:18 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 18:41:54 +0000 (11:41 -0700)
Using dev_err_cast_probe() to simplify the code.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Link: https://patch.msgid.link/20240828121805.3696631-1-lihongbo22@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/realtek/rtl83xx.c

index 35709a1756ae06838256fe1a6d3096646bb25a9e..3c5018d5e1f93b9e37a8b55bfa0986c75adf82cb 100644 (file)
@@ -185,11 +185,9 @@ rtl83xx_probe(struct device *dev,
 
        /* TODO: if power is software controlled, set up any regulators here */
        priv->reset_ctl = devm_reset_control_get_optional(dev, NULL);
-       if (IS_ERR(priv->reset_ctl)) {
-               ret = PTR_ERR(priv->reset_ctl);
-               dev_err_probe(dev, ret, "failed to get reset control\n");
-               return ERR_CAST(priv->reset_ctl);
-       }
+       if (IS_ERR(priv->reset_ctl))
+               return dev_err_cast_probe(dev, priv->reset_ctl,
+                                         "failed to get reset control\n");
 
        priv->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
        if (IS_ERR(priv->reset)) {