projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a5afe53
)
packet: move from strlcpy with unused retval to strscpy
author
Wolfram Sang
<wsa+renesas@sang-engineering.com>
Thu, 18 Aug 2022 21:02:27 +0000
(23:02 +0200)
committer
Jakub Kicinski
<kuba@kernel.org>
Tue, 23 Aug 2022 00:59:51 +0000
(17:59 -0700)
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.
Link:
https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link:
https://lore.kernel.org/r/20220818210227.8611-1-wsa+renesas@sang-engineering.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/packet/af_packet.c
patch
|
blob
|
blame
|
history
diff --git
a/net/packet/af_packet.c
b/net/packet/af_packet.c
index 5cbe07116e04e68251de863307e7194b9e07a789..7de46d8313498cf1a93ecc7a87597265d64d35d3 100644
(file)
--- a/
net/packet/af_packet.c
+++ b/
net/packet/af_packet.c
@@
-1905,7
+1905,7
@@
static int packet_rcv_spkt(struct sk_buff *skb, struct net_device *dev,
*/
spkt->spkt_family = dev->type;
- str
l
cpy(spkt->spkt_device, dev->name, sizeof(spkt->spkt_device));
+ str
s
cpy(spkt->spkt_device, dev->name, sizeof(spkt->spkt_device));
spkt->spkt_protocol = skb->protocol;
/*
@@
-3565,7
+3565,7
@@
static int packet_getname_spkt(struct socket *sock, struct sockaddr *uaddr,
rcu_read_lock();
dev = dev_get_by_index_rcu(sock_net(sk), READ_ONCE(pkt_sk(sk)->ifindex));
if (dev)
- str
l
cpy(uaddr->sa_data, dev->name, sizeof(uaddr->sa_data));
+ str
s
cpy(uaddr->sa_data, dev->name, sizeof(uaddr->sa_data));
rcu_read_unlock();
return sizeof(*uaddr);