ASoC: soc-topology: Move template info print soc_tplg_dapm_widget_create()
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Thu, 2 Sep 2021 11:23:01 +0000 (14:23 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 13 Sep 2021 00:59:04 +0000 (01:59 +0100)
A DAPM widget now can have different types of controls, it is no longer
correct to print the type as it is just the type of the first control.

Move it after the loop where we create the controls and print the number
of the control types.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20210902112301.22657-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c

index f6e5ac3e03140becc9dfc9be3d6bcdb354f29f61..73e1b7b48ce98ee85bbef2e3bfd6b16d3f1d73a4 100644 (file)
@@ -1473,10 +1473,6 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
                goto widget;
        }
 
-       control_hdr = (struct snd_soc_tplg_ctl_hdr *)tplg->pos;
-       dev_dbg(tplg->dev, "ASoC: template %s has %d controls of type %x\n",
-               w->name, w->num_kcontrols, control_hdr->type);
-
        template.num_kcontrols = le32_to_cpu(w->num_kcontrols);
        kc = devm_kcalloc(tplg->dev, le32_to_cpu(w->num_kcontrols), sizeof(*kc), GFP_KERNEL);
        if (!kc)
@@ -1536,6 +1532,8 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
        }
 
        template.kcontrol_news = kc;
+       dev_dbg(tplg->dev, "ASoC: template %s with %d/%d/%d (mixer/enum/bytes) control\n",
+               w->name, mixer_count, enum_count, bytes_count);
 
 widget:
        ret = soc_tplg_widget_load(tplg, &template, w);