ocfs2: remove unecessary variable needs_checkpoint
authorGoldwyn Rodrigues <rgoldwyn@gmail.com>
Wed, 3 Jul 2013 22:00:51 +0000 (15:00 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 3 Jul 2013 23:07:23 +0000 (16:07 -0700)
Code cleanup: needs_checkpoint is assigned to but never used.  Delete
the variable.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Cc: Jeff Liu <jeff.liu@oracle.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/journal.h
fs/ocfs2/ocfs2.h
fs/ocfs2/super.c

index a3385b63ff5e542bcfaabe59744fa3af38b537e4..0a992737dcaf8e76d0b57b18dcb21b57d5ed6479 100644 (file)
@@ -200,7 +200,6 @@ void ocfs2_complete_quota_recovery(struct ocfs2_super *osb);
 
 static inline void ocfs2_start_checkpoint(struct ocfs2_super *osb)
 {
-       atomic_set(&osb->needs_checkpoint, 1);
        wake_up(&osb->checkpoint_event);
 }
 
index d355e6e36b366bfe7dc8cc91cbabdad05976ba2c..3a903470c794ec61dace1c03f9446cfe5f388e9c 100644 (file)
@@ -347,7 +347,6 @@ struct ocfs2_super
        struct task_struct *recovery_thread_task;
        int disable_recovery;
        wait_queue_head_t checkpoint_event;
-       atomic_t needs_checkpoint;
        struct ocfs2_journal *journal;
        unsigned long osb_commit_interval;
 
index 01b85165552b75f1cf2e17893bea1054eb19ff81..854d80955bf8e66ea088a879d9faaf9178781441 100644 (file)
@@ -286,10 +286,9 @@ static int ocfs2_osb_dump(struct ocfs2_super *osb, char *buf, int len)
        spin_unlock(&osb->osb_lock);
 
        out += snprintf(buf + out, len - out,
-                       "%10s => Pid: %d  Interval: %lu  Needs: %d\n", "Commit",
+                       "%10s => Pid: %d  Interval: %lu\n", "Commit",
                        (osb->commit_task ? task_pid_nr(osb->commit_task) : -1),
-                       osb->osb_commit_interval,
-                       atomic_read(&osb->needs_checkpoint));
+                       osb->osb_commit_interval);
 
        out += snprintf(buf + out, len - out,
                        "%10s => State: %d  TxnId: %lu  NumTxns: %d\n",
@@ -2154,7 +2153,6 @@ static int ocfs2_initialize_super(struct super_block *sb,
        }
 
        init_waitqueue_head(&osb->checkpoint_event);
-       atomic_set(&osb->needs_checkpoint, 0);
 
        osb->s_atime_quantum = OCFS2_DEFAULT_ATIME_QUANTUM;