drm/msm/adreno: Remove MODULE_FIRMWARE()'s
authorRob Clark <robdclark@chromium.org>
Wed, 7 May 2025 15:47:22 +0000 (08:47 -0700)
committerRob Clark <robdclark@chromium.org>
Sat, 10 May 2025 16:06:36 +0000 (09:06 -0700)
The driver handles the case where gpu fw is not in the initrd.  OTOH it
doesn't always handle the case where _some_ fw is in the initrd, but
others are not.  In particular the zap fw tends to be signed with an OEM
specific key, so the paths/names differ across devices with the same
SoC/GPU, so we cannot sanely list them with MODULE_FIRMWARE().

So MODULE_FIRMWARE() just ends up causing problems without actually
solving anything.  Remove them!

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/652195/

drivers/gpu/drm/msm/adreno/a2xx_catalog.c
drivers/gpu/drm/msm/adreno/a3xx_catalog.c
drivers/gpu/drm/msm/adreno/a4xx_catalog.c
drivers/gpu/drm/msm/adreno/a5xx_catalog.c
drivers/gpu/drm/msm/adreno/a6xx_catalog.c

index 9ddb7b31fd988d06f15822cb637a2ac44b10773a..5ddd015f930d9a7dd04e2d2035daa0b2f5ff3f27 100644 (file)
@@ -45,8 +45,3 @@ static const struct adreno_info a2xx_gpus[] = {
        }
 };
 DECLARE_ADRENO_GPULIST(a2xx);
-
-MODULE_FIRMWARE("qcom/leia_pfp_470.fw");
-MODULE_FIRMWARE("qcom/leia_pm4_470.fw");
-MODULE_FIRMWARE("qcom/yamato_pfp.fw");
-MODULE_FIRMWARE("qcom/yamato_pm4.fw");
index 2eb6c3e937485871beafb294d4fc7e7e8ab0a466..1498e6532f62c707754502c713b3bcc60a3c1478 100644 (file)
@@ -85,8 +85,3 @@ static const struct adreno_info a3xx_gpus[] = {
        }
 };
 DECLARE_ADRENO_GPULIST(a3xx);
-
-MODULE_FIRMWARE("qcom/a300_pm4.fw");
-MODULE_FIRMWARE("qcom/a300_pfp.fw");
-MODULE_FIRMWARE("qcom/a330_pm4.fw");
-MODULE_FIRMWARE("qcom/a330_pfp.fw");
index 93519f807f87b089a4cf23f0354a1af8a63709ed..09f9f228b75e086d09f41b858a3d43dd7da6284d 100644 (file)
@@ -45,6 +45,3 @@ static const struct adreno_info a4xx_gpus[] = {
        }
 };
 DECLARE_ADRENO_GPULIST(a4xx);
-
-MODULE_FIRMWARE("qcom/a420_pm4.fw");
-MODULE_FIRMWARE("qcom/a420_pfp.fw");
index 633f3153916277b34f90acc046ed2ee04a761727..b48a636d82370ec78e2869e9d5fa96c5c9f90a95 100644 (file)
@@ -150,12 +150,3 @@ static const struct adreno_info a5xx_gpus[] = {
        }
 };
 DECLARE_ADRENO_GPULIST(a5xx);
-
-MODULE_FIRMWARE("qcom/a530_pm4.fw");
-MODULE_FIRMWARE("qcom/a530_pfp.fw");
-MODULE_FIRMWARE("qcom/a530v3_gpmu.fw2");
-MODULE_FIRMWARE("qcom/a530_zap.mdt");
-MODULE_FIRMWARE("qcom/a530_zap.b00");
-MODULE_FIRMWARE("qcom/a530_zap.b01");
-MODULE_FIRMWARE("qcom/a530_zap.b02");
-MODULE_FIRMWARE("qcom/a540_gpmu.fw2");
index f85b7e89bafbfec3f3bc4fd88f53ec5fa586e2ce..70f7ad806c34076352d84f32d62c2833422b6e5e 100644 (file)
@@ -1093,17 +1093,6 @@ static const struct adreno_info a6xx_gpus[] = {
 };
 DECLARE_ADRENO_GPULIST(a6xx);
 
-MODULE_FIRMWARE("qcom/a615_zap.mbn");
-MODULE_FIRMWARE("qcom/a619_gmu.bin");
-MODULE_FIRMWARE("qcom/a630_sqe.fw");
-MODULE_FIRMWARE("qcom/a630_gmu.bin");
-MODULE_FIRMWARE("qcom/a630_zap.mbn");
-MODULE_FIRMWARE("qcom/a640_gmu.bin");
-MODULE_FIRMWARE("qcom/a650_gmu.bin");
-MODULE_FIRMWARE("qcom/a650_sqe.fw");
-MODULE_FIRMWARE("qcom/a660_gmu.bin");
-MODULE_FIRMWARE("qcom/a660_sqe.fw");
-
 static const struct adreno_reglist a702_hwcg[] = {
        { REG_A6XX_RBBM_CLOCK_CNTL_SP0, 0x22222222 },
        { REG_A6XX_RBBM_CLOCK_CNTL2_SP0, 0x02222220 },